Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of test_utils_hyper_params_factory.py #20

Merged
merged 3 commits into from
Jan 15, 2022

Conversation

gcattan
Copy link
Collaborator

@gcattan gcattan commented Jan 13, 2022

This PR closes #11.
It is a light refactoring of the file test_utils_hyper_params_factory.py, which regroups different tests of the same method inside pytest classes, for better readability.

@gcattan gcattan marked this pull request as ready for review January 13, 2022 20:03
Copy link
Member

@qbarthelemy qbarthelemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactorization!

tests/test_utils_hyper_params_factory.py Outdated Show resolved Hide resolved
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
Copy link
Member

@qbarthelemy qbarthelemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @gcattan !

@qbarthelemy qbarthelemy merged commit 98379c7 into pyRiemann:main Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply design from pyRiemann tests
2 participants