Base functions able to process ndarray of SPD matrices #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
reviewed
Jul 8, 2022
agramfort
reviewed
Jul 8, 2022
|
can you time? and since we use here check_finite=False
it suggests numpy as what we want?
… Message ID: ***@***.***>
|
|
Comparison on 10 sets of 100 matrices, repeated 50 times. |
Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>
qbarthelemy
force-pushed
the
base_ndarrays
branch
from
fe81c80
to
d34def6
Compare
agramfort
reviewed
Jul 9, 2022
agramfort
approved these changes
Jul 9, 2022
|
thx @qbarthelemy ! |
This was referenced Jul 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves base functions to process ndarray of SPD matrices, and completes tests.
This modification will allow to remove many for-loops from code,
providing simpler and faster (using numpy broadcasting) functions (WIP).