New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fixed point covariance estimator and add **kwds arguments in Covariances #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition! You could add the whatsnew and it is good to merge.
Yep, but |
pyriemann/utils/covariance.py
Outdated
|
||
* 'corr' for correlation coefficient matrix [corr]_, | ||
* 'cov' for numpy based covariance matrix [cov]_, | ||
* 'fpcm' for fixed point covariance matrix [fpcm]_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the name not super informative and reading the PR it's not super clear what it is useful for and why I should use it? Can you add a blob of text somewhere to explain this?
🙏
What am I missing here @qbarthelemy ? See the estimate is very different from Id matrix. |
Good catch @agramfort ! I had naively translated code from Matlab covariance toolbox https://github.com/alexandrebarachant/covariancetoolbox/blob/master/lib/estimation/FPCov.m It is corrected and I have completed tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
victory !
Feel free to just add a line in what's new saying that it's a robust estimator.
+1 for MRG
thx @qbarthelemy
Thanks @qbarthelemy for the PR and thank you @agramfort for spotting this! |
This PR:
Covariances
, for parameters passed directly to the covariance estimator.