Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add squared argument to distances #246

Merged
merged 4 commits into from May 28, 2023

Conversation

qbarthelemy
Copy link
Member

Many distances need to compute a square root to output final value,
but many algorithms require the squared distances.

Adding a squared argument to all distances allows to avoid these useless computations.

@agramfort agramfort merged commit 4bdcbe5 into pyRiemann:master May 28, 2023
10 checks passed
@agramfort
Copy link
Member

Thx @qbarthelemy

@qbarthelemy qbarthelemy deleted the utils_distance_squared branch May 29, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants