Add sample_weight parameter in TLCenter, TLStretch and TLRotate #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qbarthelemy
requested changes
Dec 6, 2023
There was a problem hiding this comment.
Thx @apmellot for this contribution!
Can you complete tests with sample weights different from None?
agramfort
reviewed
Dec 6, 2023
|
The tests now include sample_weight different from None. |
qbarthelemy
approved these changes
Dec 7, 2023
|
Ah! tests with weights failed https://github.com/pyRiemann/pyRiemann/actions/runs/7127343018/job/19407055709?pr=273#step:7:108 |
|
Hi there, thanks @apmellot for your help! I'm accepting this PR and would like to point out that |
plcrodrigues
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sylvchev @agramfort
Following the discussion we had. I added a sample_weight parameter in .fit and .fit_transform in the 3 transfer learning classes. I tested it, and it runs properly.