Rename HankelCovariances into TimeDelayCovariances #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
reviewed
Jan 3, 2024
qbarthelemy
force-pushed
the
hankelcov_deprecate
branch
from
d9a42a2
to
7fc4570
Compare
agramfort
reviewed
Jan 10, 2024
agramfort
reviewed
Jan 11, 2024
qbarthelemy
force-pushed
the
hankelcov_deprecate
branch
from
c512e38
to
3ceb45a
Compare
|
@agramfort , I'm going to merge if you don't have any other comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to explicitly test if
HankelCovarianceswere Hankel matrices, ie with constant anti-diagonals. And that's not the case.I therefore suggest to deprecate the name to
TimeDelayCovariances.