Add LLE kernel option #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qbarthelemy
requested changes
Apr 11, 2024
There was a problem hiding this comment.
Thanks @gabelstein for this improvement!
My major comment is that it is not necessary to add a new parameter kernel: extending metric should be enough.
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
qbarthelemy
reviewed
Apr 12, 2024
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
…yRiemann into LLE_kernel_callable
qbarthelemy
reviewed
Apr 15, 2024
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
…yRiemann into LLE_kernel_callable
qbarthelemy
approved these changes
Apr 15, 2024
|
Thx @gabelstein ! |
qbarthelemy
added a commit
that referenced
this pull request
Apr 17, 2024
* Adding Euclidean Alignment as implemented in the paper * Organizing code * Organizing code * resolving comments * prepare release 0.6 (#291) * Adapting TLCenter * update release and year * simplify code and complete doc * Add LLE kernel option (#293) * Add kernel option and tests * Update whatsnew.rst * Update whatsnew.rst * Apply suggestions from code review Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com> * lint * improve whatsnew * Apply suggestions from code review Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com> * linting * add none kernel test * might needed for flake8 * Update embedding.py * Delete .idea/workspace.xml * Update test_embedding.py * Update test_embedding.py * Apply suggestions from code review Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com> * change error * linting --------- Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com> * deleting 'euclidean.py' file * fixing flake8 errors * updating whatsnew file * move contrib to version 0.7 in whatsnew --------- Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com> Co-authored-by: Gabriel Wagner vom Berg <42769425+gabelstein@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a kernel option to LLE to make it more flexible.
Also, it allows for new parameter 'None' for n_neighbors and n_components to be more similar to e.g. KernelPCA from scikit-learn.