Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing "bias" method to the interface of the verification module #330

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

Joep1999
Copy link
Contributor

@Joep1999 Joep1999 commented Jun 8, 2023

The BIAS method was not available with the 'get method' function, because it was missing from the name list. Therefore I added it.

The BIAS method was not available with the 'get method' function, because it was missing from the name list. Therefore I added it.
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (500f23e) 83.34% compared to head (d2afb13) 83.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #330   +/-   ##
=======================================
  Coverage   83.34%   83.34%           
=======================================
  Files         161      161           
  Lines       12355    12355           
=======================================
  Hits        10297    10297           
  Misses       2058     2058           
Flag Coverage Δ
unit_tests 83.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pysteps/verification/interface.py 46.80% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@dnerini dnerini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Joep1999, very good, many thanks for the valuable contribution!

@dnerini dnerini changed the title Update interface.py Add missing "bias" method to the interface of the verification module Jun 9, 2023
@dnerini dnerini merged commit ae849fd into pySTEPS:master Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants