Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sadly onnxruntime-gpu dependency kills Mac support #1505

Closed
dr-duplo opened this issue Oct 19, 2023 · 11 comments
Closed

Sadly onnxruntime-gpu dependency kills Mac support #1505

dr-duplo opened this issue Oct 19, 2023 · 11 comments

Comments

@dr-duplo
Copy link

dr-duplo commented Oct 19, 2023

Hi, thanks for the great package. Sadly the recently (3.0.1) introduced onnxruntime-gpu dependency kills Mac support. At least on M2 (didn't try anything else).

Describe the solution you'd like

@github-actions
Copy link

Thank you for your issue.You might want to check the FAQ if you haven't done so already.

Feel free to close this issue if you found an answer in the FAQ.

If your issue is a feature request, please read this first and update your request accordingly, if needed.

If your issue is a bug report, please provide a minimum reproducible example as a link to a self-contained Google Colab notebook containing everthing needed to reproduce the bug:

  • installation
  • data preparation
  • model download
  • etc.

Providing an MRE will increase your chance of getting an answer from the community (either maintainers or other power users).

Companies relying on pyannote.audio in production may contact me via email regarding:

  • paid scientific consulting around speaker diarization and speech processing in general;
  • custom models and tailored features (via the local tech transfer office).

This is an automated reply, generated by FAQtory

@hbredin
Copy link
Member

hbredin commented Oct 19, 2023

Can you please clarify what you mean by "kills Mac support"?
I actually happen to develop pyannote on a Mac...

@dr-duplo
Copy link
Author

I wasn't able to install pyannote.audio due to a missing install candidate for onnxruntime-gpu. I'm on a M2.

@hbredin
Copy link
Member

hbredin commented Oct 19, 2023

Unfortunately I don't own an M2 mac myself (M1, it is).
To pyannote M2 users out there, could anyone help @dr-duplo with that?

@guilhermehge
Copy link

You can just use a previous version of pyannote.audio. Find a commit before 3.0.1 and install it.

@reubinoff
Copy link

I have mac with intel chipset and same for me. I cannot install version 3.0.1 only 3.0.0

@guilhermehge
Copy link

This is simply because onnxruntime-gpu does not have mac support.

@chrisbrickhouse
Copy link

I reproduced the issue in our CI pipeline, you can see the build failure on macos-latest caused by pyannote.

ERROR: Could not find a version that satisfies the requirement onnxruntime-gpu>=1.16.0 (from pyannote-audio) (from versions: none)
ERROR: No matching distribution found for onnxruntime-gpu>=1.16.0

You can just use a previous version of pyannote.audio. Find a commit before 3.0.1 and install it.

While this is a viable workaround, it shouldn't be the solution. Breaking compatibility with an entire operating system shouldn't be introduced with a patch bump, and the loss of interoperability between 3.0.0 and 3.0.1 should be considered a bug.

The OP's suggestion of platform dependent requirements seems like a good middle path between backwards compatibility and fixing the bug which required the new dependency.

@hbredin
Copy link
Member

hbredin commented Oct 25, 2023

Thanks for the feedback.

Would any of you be willing to contribute to the project by opening a PR solving this issue?

@dr-duplo
Copy link
Author

Thanks for the feedback.

Would any of you be willing to contribute to the project by opening a PR solving this issue?

I can do, but may need help to test it on other machines.

dr-duplo added a commit to dr-duplo/pyannote-audio that referenced this issue Oct 25, 2023
This patch alters the requirements to use another ONNX runtime package which provides pre-build wheels for for Apple Silicon in case of running on arm64/M1/M2 Mac.

Fixes pyannote#1505
@hbredin
Copy link
Member

hbredin commented Nov 16, 2023

Closing as latest version no longer relies on ONNX runtime.
Please update to pyannote.audio 3.1 and pyannote/speaker-diarization-3.1 (and open new issues if needed).

@hbredin hbredin closed this as completed Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants