Adding inplace argument and expanding docs info for factorize #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding unit test too.
germa89
added
Documentation
|
|
Codecov Report
@@ Coverage Diff @@
## main #1489 +/- ##
==========================================
+ Coverage 80.58% 80.66% +0.07%
==========================================
Files 43 43
Lines 6813 6836 +23
==========================================
+ Hits 5490 5514 +24
+ Misses 1323 1322 -1 |
germa89
changed the title
germa89
added a commit
that referenced
this pull request
Oct 11, 2022
* Adding inplace argument and expanding docs info. Adding unit test too. * Changing function name. * Improving docs.
germa89
added a commit
that referenced
this pull request
Oct 24, 2022
* Initial commit for krylov method * Review feedbacks incorporated * Fixing style and codacity. * Fixing local/remote full file check. * Removing mapdl.directory from output writing. * Adding upload to the `mapdl.use`. * Adding wrap to mapdl.use * Making mapdl.use return response * Adding unit tests. * Add User guide and example doc * Add User guide and example doc * Revert to old math.py code to check resolution of unit test failures * adding krylov error to permitted errors. * Break down krygensub method into smaller functions and modified doc string * Updated test cases to run with cdb and added skip for version other than 222 and 231 * update wrap of mapdl.use to fix arg passing * update example doc * Updated test to check server version before running test * Fixing version 222 * Adding inplace argument and expanding docs info for factorize (#1489) * Adding inplace argument and expanding docs info. Adding unit test too. * Changing function name. * Improving docs. * Bringing in _parm PR * Fixing check against `_parm` * Removing duplicated unit test * Fixing permission issue. * Removing trailing spacing * Fixing permission issue in Kryexpand method * First review * formatting issues. * Modifying tests to use array for assert * Changing unit test assert tolerance * Changing unit test to assert only final results * Remove macro files and unused array from test * Fix Doc Issues * Adding doc example to octree * modify test case to assert with higher tolerance * remove print statements from test * Fix codacy * Resetting cache * Testing upload multiple coverages * Matching future PR * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com> Co-authored-by: German <28149841+germa89@users.noreply.github.com> * Refactoring krylov class. * removing smp section * Apply suggestions from code review * Reducing lenght line. * Apply the most of Kathy suggestions Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com> * Applying Kathy's changes. First part. * Small changes. * reseting cache * Adding docstrings to avoid complains when building docs * Implement feedback from doc review * Shortening docstring and fixing style. Co-authored-by: German <germanmartinezayuso@gmail.com> Co-authored-by: German <28149841+germa89@users.noreply.github.com> Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is heavily related to #1465.
Adding unit test too.
Close #1488