-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MainWindow
variant on Container
, and MainFunctionGui
#110
Conversation
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
==========================================
+ Coverage 87.35% 90.24% +2.88%
==========================================
Files 25 25
Lines 2405 2420 +15
==========================================
+ Hits 2101 2184 +83
+ Misses 304 236 -68
Continue to review full report at Codecov.
|
This is awesome! Thank you so much. One quirk - for some reason I can edit the text of the "Documentation" pop up text box. But other than that it's perfect. |
ok great! Just wanted to make sure we're on the right track... Next I can make the documentation window look better, and un-editable. I was thinking of perhaps parsing the docstrings and formatting as html, do you like that? Or shall we just leave as plaintext |
Well now that you mention it... :D It will definitely be nice to have, but not a top priority. |
Very nice! I believe that the main docstring is in italics for some reason. Do you see it as well? Also, would you like me to add examples, docs, use cases, whatever? |
fixed
that would be super helpful! Perhaps another example (I'm using Maybe make a new PR for us to discuss it, though I'd like to add some more tests here before merging this one, is that ok? |
Sure thing. |
MainWindow
variant on Container
MainWindow
variant on Container
, and MainFunctionGui
@HagaiHargil, here's a start. This adds a new
MainWindow
widget type, that has one (currently) new method:self.create_menu_item("Menu Name", "Menu Item Name", callback=some_callback_when_selected, shortcut='keyboard shortcut')
if you use
magicgui(main_window=True)
you get one with the docstring in the help menu. give it a try (seeexamples/widget_demo.py
) and let me know if this general idea might work for you