More docs for main_window flag #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
=======================================
Coverage 90.24% 90.25%
=======================================
Files 25 25
Lines 2420 2421 +1
=======================================
+ Hits 2184 2185 +1
Misses 236 236
Continue to review full report at Codecov.
|
tlambert03
reviewed
Jan 22, 2021
There was a problem hiding this comment.
This is awesome @HagaiHargil, thank you so much!
I've merged the mainwindow PR, so can you merge master back into this PR and push again?
I've left a few nitpicky requests. Much appreciated!
|
|
||
|
|
||
| class HotdogOptions(Enum): | ||
| """All hotdog possibilities""" |
|
oh one more thing... can you add the following line to - file: usage/main_window |
Co-authored-by: Talley Lambert <talley.lambert@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a documentation entry for the main window feature as well as an example script.
I also introduced a very small modification for the code itself - the tooltip parser now removes backticks from the parameters' descriptions.
I wasn't sure whether you want it based on current master or on #110, so I went with the latter. It also simplifies that small fix I just described, but I can obviously do whatever you like here.