Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typesafety checks with numpy 1.20 #141

Merged
merged 4 commits into from
Jan 31, 2021

Conversation

tlambert03
Copy link
Member

the new numpy release caused a couple new (correct) errors in type hints... which is great! this fixes those so that the typesafety tests can work with numpy 1.20

@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #141 (ad7742e) into master (46cabd5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   90.97%   90.97%           
=======================================
  Files          25       25           
  Lines        2526     2526           
=======================================
  Hits         2298     2298           
  Misses        228      228           
Impacted Files Coverage Δ
magicgui/widgets/_table.py 96.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46cabd5...ad7742e. Read the comment docs.

@tlambert03 tlambert03 merged commit 2579a8c into pyapp-kit:master Jan 31, 2021
@tlambert03 tlambert03 deleted the numpy120-types branch January 31, 2021 16:51
@tlambert03 tlambert03 added the bug Something isn't working label Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant