Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix function with no params and callbutton #149

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

tlambert03
Copy link
Member

This fixes a bug when creating a vertically oriented magicgui with call_button=True, when there are no parameters in the function

closes #146

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #149 (a9a9333) into master (f2955c3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   91.24%   91.25%           
=======================================
  Files          25       25           
  Lines        2502     2503    +1     
=======================================
+ Hits         2283     2284    +1     
  Misses        219      219           
Impacted Files Coverage Δ
magicgui/widgets/_bases/container_widget.py 94.93% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2955c3...a9a9333. Read the comment docs.

@tlambert03 tlambert03 merged commit aaa4eb9 into master Feb 10, 2021
@tlambert03 tlambert03 deleted the fix-btn-with-no-params branch February 10, 2021 20:00
@tlambert03 tlambert03 added the bug Something isn't working label Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vertical layout with no widgets error in _unify_label_widths
1 participant