-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add RadioButtons
widget
#183
Conversation
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
+ Coverage 90.06% 90.07% +0.01%
==========================================
Files 29 29
Lines 2908 2982 +74
==========================================
+ Hits 2619 2686 +67
- Misses 289 296 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! By default will you get the opposite orientation of the orientation of the main layout if possible? So always some combo of vertical + horizontal. Or is that maybe too magical? You could always fallback on a single default if nothing else makes sense
I was just gonna stick with vertical by default... someone won't like the magic :) |
fine with me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
This adds
widgets.RadioButtons
which has the same API aswidgets.ComboBox
(with the addition of anorientation
parameter). Currently, only exclusive radio groups are supported.shown here with horizontal orientation in a vertical layout: