Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize _qt module #32

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Reorganize _qt module #32

merged 1 commit into from
Jul 13, 2020

Conversation

tlambert03
Copy link
Member

the single file was getting a bit long. Splitting into different files.
This also allows /_qt/__init__.py to start to reveal what the backend "API" is... and what we would need to implement to add a new widget backend.

@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #32 into master will increase coverage by 0.14%.
The diff coverage is 96.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   95.61%   95.76%   +0.14%     
==========================================
  Files           4       13       +9     
  Lines         890      921      +31     
==========================================
+ Hits          851      882      +31     
  Misses         39       39              
Impacted Files Coverage Δ
magicgui/_qt/widgets/file_dialog.py 93.84% <93.84%> (ø)
magicgui/_qt/_qt.py 95.12% <95.12%> (ø)
magicgui/_qt/constants.py 95.45% <95.45%> (ø)
magicgui/_qt/__init__.py 100.00% <100.00%> (ø)
magicgui/_qt/categorical.py 100.00% <100.00%> (ø)
magicgui/_qt/types.py 100.00% <100.00%> (ø)
magicgui/_qt/widgets/__init__.py 100.00% <100.00%> (ø)
magicgui/_qt/widgets/data_combobox.py 100.00% <100.00%> (ø)
magicgui/_qt/widgets/double_slider.py 100.00% <100.00%> (ø)
magicgui/_qt/widgets/widget.py 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc172d7...70e08d2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant