Moved _frangeChanged for LabeledSliders #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QLabeledRangeSlider needs _frangeChange, it's been moved from QLabeledDoubleRangeSlider. _GenericSlider uses floats for the range
Codecov Report
@@ Coverage Diff @@
## main #111 +/- ##
==========================================
- Coverage 84.94% 83.92% -1.02%
==========================================
Files 30 30
Lines 2391 2389 -2
==========================================
- Hits 2031 2005 -26
- Misses 360 384 +24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
thanks for the fix @david-jenkins! Could you by chance add a test that would prevent a regression on this? (and also help us make sure it works across all the backends being tested here) |
tlambert03
approved these changes
Oct 3, 2022
tlambert03
reviewed
Oct 3, 2022
There was a problem hiding this comment.
also, this now makes it that QLabeledRangeSlider (the non double version) emits a float... which is not what we want:
In [1]: from superqt import QLabeledRangeSlider
In [3]: s = QLabeledRangeSlider()
In [4]: s.rangeChanged.connect(print)
Out[4]: <PyQt5.QtCore.QMetaObject.Connection object at 0x10d917ca0>
In [6]: s.setRange(0,10)
0.0 10.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where rangeChanged expected integers.
The _GenericSlider class uses floats for the range and so QLabeledRangeSlider needs to have the _frangeChanged signal
This moves it from QLabeledDoubleRangeSlider