Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DFN as ODEs #247

Closed
Scottmar93 opened this issue Apr 3, 2019 · 0 comments · Fixed by #842
Closed

Implement DFN as ODEs #247

Scottmar93 opened this issue Apr 3, 2019 · 0 comments · Fixed by #842
Assignees
@Scottmar93
Labels
feature

Comments

@Scottmar93
Copy link
Contributor

Summary
Implement the ODE version of the DFN using the capacitance trick.

Motivation
This may offer a faster solution method than solving the DAEs. We can compare the two formulations and determine which is best
@Scottmar93 Scottmar93 added this to To do in One-dimensional models via automation Apr 3, 2019
@Scottmar93 Scottmar93 self-assigned this Apr 8, 2019
@Scottmar93 Scottmar93 removed this from To do in One-dimensional models Apr 16, 2019
valentinsulzer added a commit that referenced this issue Feb 5, 2020
@valentinsulzer
#247 start dfn as odes
892d954
valentinsulzer added a commit that referenced this issue Feb 5, 2020
@valentinsulzer
#247 add tests
50980b5
valentinsulzer added a commit that referenced this issue Feb 5, 2020
@valentinsulzer
#247 merge master
5d5db8f
valentinsulzer added a commit that referenced this issue Feb 5, 2020
@valentinsulzer
#247 merge master
49ca692
valentinsulzer added a commit that referenced this issue Feb 18, 2020
@valentinsulzer
#247 merge master
96e4130
valentinsulzer added a commit that referenced this issue Feb 19, 2020
@valentinsulzer
#247 merge master
fe7995a
valentinsulzer added a commit that referenced this issue Feb 19, 2020
@valentinsulzer
#247 fix processed variable
ec948de
valentinsulzer added a commit that referenced this issue Feb 19, 2020
@valentinsulzer
#247 fix quickplot
e006b17
@valentinsulzer valentinsulzer mentioned this issue Feb 19, 2020
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Feb 19, 2020
@valentinsulzer
#247 try casadi solver for experiment ...
37d331d
valentinsulzer added a commit that referenced this issue Feb 19, 2020
@valentinsulzer
#247 changelog
36aa13b
valentinsulzer added a commit that referenced this issue Feb 21, 2020
@valentinsulzer
#247 merge master
ccae1df
valentinsulzer added a commit that referenced this issue Feb 21, 2020
@valentinsulzer
#247 codacy
79cbec9
valentinsulzer added a commit that referenced this issue Feb 24, 2020
@valentinsulzer
#247 fix parameter printing
5a0690a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Scottmar93 Scottmar93

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 247 dfn as odes pybamm-team/PyBaMM
1 participant
@Scottmar93