Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 247 dfn as odes #842

Merged
merged 15 commits into from
Feb 24, 2020
Merged

Issue 247 dfn as odes #842

merged 15 commits into from
Feb 24, 2020

Conversation

valentinsulzer
Copy link
Member

Description

Implement ODE formulation of the DFN

Fixes #247

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@36aa13b). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #842   +/-   ##
=========================================
  Coverage          ?   98.28%           
=========================================
  Files             ?      180           
  Lines             ?    10518           
  Branches          ?        0           
=========================================
  Hits              ?    10338           
  Misses            ?      180           
  Partials          ?        0
Impacted Files Coverage Δ
pybamm/solvers/idaklu_solver.py 89.21% <ø> (ø)
pybamm/solvers/casadi_solver.py 100% <ø> (ø)
pybamm/solvers/scikits_dae_solver.py 98.07% <ø> (ø)
pybamm/parameters/print_parameters.py 96.96% <ø> (ø)
pybamm/solvers/base_solver.py 99.42% <100%> (ø)
...odels/full_battery_models/lithium_ion/basic_spm.py 100% <100%> (ø)
...odels/full_battery_models/lithium_ion/basic_dfn.py 100% <100%> (ø)
...bamm/parameters/standard_parameters_lithium_ion.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36aa13b...5a0690a. Read the comment docs.

Copy link
Contributor

@Scottmar93 Scottmar93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@valentinsulzer valentinsulzer merged commit ea6ed83 into master Feb 24, 2020
@valentinsulzer valentinsulzer deleted the issue-247-dfn-as-odes branch February 24, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement DFN as ODEs
2 participants