Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NCA parameter set #821

Closed
Scottmar93 opened this issue Feb 12, 2020 · 0 comments · Fixed by #824
Closed

Add NCA parameter set #821

Scottmar93 opened this issue Feb 12, 2020 · 0 comments · Fixed by #824
Assignees
@Scottmar93
Labels
feature

Comments

@Scottmar93
Copy link
Contributor

Scottmar93 commented Feb 12, 2020 •
edited

Add NCA parameter set from:

Kim, G. H., Smith, K., Lee, K. J., Santhanagopalan, S., & Pesaran, A. (2011). Multi-domain modeling of lithium-ion batteries encompassing multi-physics in varied length scales. Journal of The Electrochemical Society, 158(8), A955-A969.
@Scottmar93 Scottmar93 self-assigned this Feb 12, 2020
Scottmar93 added a commit that referenced this issue Feb 12, 2020
@Scottmar93
#821 added kim parameter set
f01d080
Scottmar93 added a commit that referenced this issue Feb 12, 2020
@Scottmar93
#821 NCA set working with models
5d7c5d8
Scottmar93 added a commit that referenced this issue Feb 12, 2020
@Scottmar93
#821 removed null functions
7e06f15
@Scottmar93 Scottmar93 mentioned this issue Feb 12, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Scottmar93 Scottmar93

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 821 add nca set pybamm-team/PyBaMM
1 participant
@Scottmar93