Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 821 add nca set #824

Merged
merged 3 commits into from Feb 13, 2020
Merged

Issue 821 add nca set #824

merged 3 commits into from Feb 13, 2020

Conversation

Scottmar93
Copy link
Contributor

Description

Added the NCA parameter set from Kim2011 (see issue). t+ should still entered as a function and volumetric heat generation is only correct for the full cell averaged case.

Fixes #821

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #824 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #824      +/-   ##
==========================================
+ Coverage   98.19%   98.25%   +0.05%     
==========================================
  Files         181      181              
  Lines       10243    10468     +225     
==========================================
+ Hits        10058    10285     +227     
+ Misses        185      183       -2     
Impacted Files Coverage Δ
...bamm/parameters/standard_parameters_lithium_ion.py 100.00% <0.00%> (ø) ⬆️
...amm/models/submodels/porosity/constant_porosity.py 100.00% <0.00%> (ø) ⬆️
...odels/full_battery_models/lithium_ion/basic_dfn.py 100.00% <0.00%> (ø) ⬆️
pybamm/spatial_methods/finite_volume.py 97.97% <0.00%> (+0.22%) ⬆️
pybamm/expression_tree/symbol.py 97.97% <0.00%> (+0.25%) ⬆️
pybamm/expression_tree/concatenations.py 99.51% <0.00%> (+1.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4af8ed4...7e06f15. Read the comment docs.

@Scottmar93 Scottmar93 merged commit bc96ffd into master Feb 13, 2020
@valentinsulzer valentinsulzer deleted the issue-821-add-NCA-set branch February 17, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NCA parameter set
2 participants