Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pouch cell initial conditions #953

Closed
rtimms opened this issue Apr 13, 2020 · 0 comments · Fixed by #954
Closed

pouch cell initial conditions #953

rtimms opened this issue Apr 13, 2020 · 0 comments · Fixed by #954
Assignees
Labels
bug Something isn't working

Comments

@rtimms
Copy link
Contributor

rtimms commented Apr 13, 2020

The potential_pair model sets the initial conditions uses applied_current = variables["Total current density"]. For non-constant current discharge this is part of the statevector and leads to a discretisation error (the initial conditions aren't a numpy array). For now, his should be replaced with applied_current = self.param.current_with_time.

Question: are there any cases where it would be convenient to set ICs in terms of another variable (provided ICs set for that variable evaluate to a numpy array)?

@rtimms rtimms added the bug Something isn't working label Apr 13, 2020
@rtimms rtimms self-assigned this Apr 13, 2020
rtimms added a commit that referenced this issue Apr 13, 2020
rtimms added a commit that referenced this issue Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant