#953-change-initial-conditions

[rtimms]

Description

Fixes an issue with initial conditions in the pouch cell models when not doing constant current.

Fixes #953

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

Merging #954 into develop will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #954      +/-   ##
===========================================
+ Coverage    98.10%   98.22%   +0.11%     
===========================================
  Files          223      239      +16     
  Lines        11258    12510    +1252     
===========================================
+ Hits         11045    12288    +1243     
- Misses         213      222       +9     

Impacted Files	Coverage Δ
...dels/submodels/current_collector/potential_pair.py	100.00% <100.00%> (ø)
...amm/models/submodels/convection/base_convection.py	83.92% <0.00%> (-16.08%)	⬇️
...mm/models/submodels/interface/diffusion_limited.py	97.29% <0.00%> (-0.82%)	⬇️
...dels/full_battery_models/lead_acid/higher_order.py	98.55% <0.00%> (-0.44%)	⬇️
pybamm/solvers/base_solver.py	99.33% <0.00%> (-0.40%)	⬇️
...m/models/full_battery_models/base_battery_model.py	99.74% <0.00%> (-0.26%)	⬇️
pybamm/parameters/standard_parameters_lead_acid.py	99.25% <0.00%> (-0.03%)	⬇️
pybamm/models/standard_variables.py	100.00% <0.00%> (ø)
pybamm/models/submodels/porosity/base_porosity.py	100.00% <0.00%> (ø)
pybamm/spatial_methods/zero_dimensional_method.py	100.00% <0.00%> (ø)
... and 35 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11d62d6...3c12c7e. Read the comment docs.