Repository navigation
Remove anytree - #1912
Merged
Merged
Remove anytree#1912
Conversation
Member
Author
Codecov Report
@@ Coverage Diff @@
## develop #1912 +/- ##
========================================
Coverage 99.32% 99.33%
========================================
Files 346 346
Lines 19135 19105 -30
========================================
- Hits 19006 18977 -29
+ Misses 129 128 -1
Continue to review full report at Codecov.
|
martinjrobins
approved these changes
Jan 22, 2022
martinjrobins
left a comment
Contributor
There was a problem hiding this comment.
this looks great, glad to be rid of anytree!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
It seems like we can get away with not using
anytreewhen creating expression trees, which saves a fair amount of overhead. Functionality likerenderstill works fine, as long as the symbol has achildrenattribute.Symbol.new_copyno longer needs to be used, but I have left the functions there in case we need to go back.Let's give it a couple of releases to be sure, but if things are working well without
anytreewe can also:Symbol.idand implement__eq__and__hash__instead (previously, these were not implemented to avoid loops in anytree)model.new_copyto just make shallow copiesI'll open an issue for that if this PR is approved.
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: