Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems like we can get away with not using
anytree
when creating expression trees, which saves a fair amount of overhead. Functionality likerender
still works fine, as long as the symbol has achildren
attribute.Symbol.new_copy
no longer needs to be used, but I have left the functions there in case we need to go back.Let's give it a couple of releases to be sure, but if things are working well without
anytree
we can also:Symbol.id
and implement__eq__
and__hash__
instead (previously, these were not implemented to avoid loops in anytree)model.new_copy
to just make shallow copiesI'll open an issue for that if this PR is approved.
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: