Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #2670]: Replaced interp2d into RegularGridInterpolator in ProcessedVariable #2706

Closed

Conversation

jaskiratsingh2000
Copy link

Description

This denotes the modified code with RegularGridInterpolator instead of interp2d

Fixes #2670

Type of change

Improvement

@jaskiratsingh2000
Copy link
Author

@rtimms , @jeromtom , and @tinosulzer Could you review it once above? Thanks!

@jaskiratsingh2000
Copy link
Author

@rtimms Should I make the new PR for the same and reference it here?

@Saransh-cpp
Copy link
Member

You can commit and push on the same branch. It will automatically show up on this PR.

@jaskiratsingh2000
Copy link
Author

@Saransh-cpp I made the new commits to the patch-1 branch but that didn't show up somehow.

@jaskiratsingh2000
Copy link
Author

@rtimms I made the requested changes above.

@Saransh-cpp
Copy link
Member

You might not have pushed the commit. Please feel free to close this PR if #2709 does the job.

@jaskiratsingh2000
Copy link
Author

Great! I'm looking forward to hearing from others on the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace interp2d in ProcessedVariable
3 participants