Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jax to 0.4.8 #2927

Merged
merged 6 commits into from
May 9, 2023
Merged

Conversation

jsbrittain
Copy link
Contributor

Description

Update Jax (from 0.2.12 to 0.4.8) and JaxLib (from 0.1.70 to 0.4.7). There were several breaking changes in the Jax interface between these versions.

Fixes #1625

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
    Refactor of existing code

Note: The Jax library appears to be evolving rapidly, so I have pinned the current version.

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (1928b19) 99.68% compared to head (6f3aa4c) 99.71%.

❗ Current head 6f3aa4c differs from pull request most recent head 6017d47. Consider uploading reports for the commit 6017d47 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2927      +/-   ##
===========================================
+ Coverage    99.68%   99.71%   +0.02%     
===========================================
  Files          273      273              
  Lines        18997    18991       -6     
===========================================
- Hits         18938    18936       -2     
+ Misses          59       55       -4     
Impacted Files Coverage Δ
...bamm/expression_tree/operations/evaluate_python.py 99.29% <ø> (ø)
pybamm/solvers/jax_bdf_solver.py 98.89% <100.00%> (+0.85%) ⬆️
pybamm/util.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsbrittain jsbrittain marked this pull request as ready for review May 4, 2023 18:43
Copy link
Sponsor Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! Happy to merge one Martin has reviewed it

Copy link
Contributor

@martinjrobins martinjrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks @jsbrittain

@martinjrobins martinjrobins merged commit 617dc3b into pybamm-team:develop May 9, 2023
@jsbrittain jsbrittain deleted the issue-1625-jax branch May 10, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update jax version
4 participants