Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all contribs badge #4088

Merged
merged 2 commits into from
May 14, 2024
Merged

Fix all contribs badge #4088

merged 2 commits into from
May 14, 2024

Conversation

kratman
Copy link
Contributor

@kratman kratman commented May 14, 2024

Description

This should fix the badge issue.

Fixes #4086

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@kratman kratman self-assigned this May 14, 2024
@kratman kratman marked this pull request as ready for review May 14, 2024 13:50
@kratman
Copy link
Contributor Author

kratman commented May 14, 2024

@brosaplanella I think this should work. I will trigger the bot after this to confirm it works

@kratman kratman merged commit 0cb34a1 into pybamm-team:develop May 14, 2024
39 of 40 checks passed
@kratman kratman mentioned this pull request May 14, 2024
6 tasks
@kratman kratman deleted the fix/allContribs branch June 5, 2024 21:53
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All contributors badge does not update
2 participants