Make implicit conversions non-reentrant (fixes #1035) #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjakob
changed the title
wjakob
force-pushed
the
master
branch
2 times, most recently
from
d33d1c0
to
b4b9c9d
Compare
|
Weird.. not sure I understand these CI failures. |
|
Try an empty copy constructor instead of an explicitly defaulted one: BogusImplicitConversion(const BogusImplicitConversion &) {}Early C++11 compilers had a bug where braces would prefer aggregate initialization over copy constructors. A struct with an explicitly defaulted copy constructor is still considered an aggregate. (Here, the aggregate initializer takes 0 arguments, so that's why it's complaining about 'too many arguments'.) |
|
Thank you for the suggestion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #1035