Fix warning in C++17 mode. #1191
Conversation
|
Thank you -- this looks good to me. |
|
It looks good to me. I've also pushed another commit to this branch that adds |
|
Aha, that caught some more. Another commit pushed to address them. |
|
I got a few more methinks, but I cannot reproduce the eigen3 error on my setup. |
Also rework the eigen download to extract on the fly, and to extract to 'eigen' rather than 'eigen-eigen-12345...'.
jagerman
force-pushed
the
warning_fix
branch
from
cb1dabe
to
7709906
Compare
|
Perhaps it was fixed in 3.3.4; I've pushed a change to update it to see if that fixes it. (Edit: forced pushed: the first attempt was broken). |
These warnings are coming from Eigen, which we can't do anything about, so just disable the warning.
|
Okay, they are all solved now. Upgrading to Eigen 3.3.4 didn't change anything, so I just disabled |
This commit turns on `-Wdeprecated` in the test suite and fixes several associated deprecation warnings that show up as a result: - in C++17 `static constexpr` members are implicitly inline; our redeclaration (needed for C++11/14) is deprecated in C++17. - various test suite classes have destructors and rely on implicit copy constructors, but implicit copy constructor definitions when a user-declared destructor is present was deprecated in C++11. - Eigen also has various implicit copy constructors, so just disable `-Wdeprecated` in `eigen.h`.
|
This is now merged into |
In C++17, static constexpr members are implicitly inline and it's deprecated to re-declare them outside the class. This fixes a GCC 7.2
-Wdeprecatedwarning in C++17 mode.