CMake: Remember Python Version #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
pushed a commit
to ax3l/openPMD-api
that referenced
this pull request
Jun 20, 2018
Add an internal version of pybind11, version 2.2.3. Modifications from the releases: - add fix pybind/pybind11#1434 - remove test dirs - remove wheel packaging (setup.py/cfg) - remove github templates
ax3l
force-pushed
the
fix-addSubdirPythonVersion
branch
from
50a1937
to
0a59021
Compare
|
Is it possible the CI linux python 3.6.6 test is broken in |
ax3l
pushed a commit
to ax3l/openPMD-api
that referenced
this pull request
Jun 21, 2018
Add an internal version of pybind11, version 2.2.3. Modifications from the releases: - add fix pybind/pybind11#1434 - remove test dirs - remove wheel packaging (setup.py/cfg) - remove github templates
It is useful not only to remember the python libs and includes but also the interpreter version in cache. If users call pybind11 throught `add_subdirectories` they will otherwise have no access to the selected interpreter version. The interpreter version is useful for downstream projects, e.g. to select default `lib/pythonX.Y/site-packages/` install paths.
ax3l
force-pushed
the
fix-addSubdirPythonVersion
branch
from
0a59021
to
f0601dd
Compare
|
@chuckatkins any thoughts on this one as well? |
|
Thanks! |
wjakob
pushed a commit
that referenced
this pull request
Sep 11, 2018
It is useful not only to remember the python libs and includes but also the interpreter version in cache. If users call pybind11 throught `add_subdirectories` they will otherwise have no access to the selected interpreter version. The interpreter version is useful for downstream projects, e.g. to select default `lib/pythonX.Y/site-packages/` install paths.
ax3l
pushed a commit
to ax3l/openPMD-api
that referenced
this pull request
Jun 15, 2019
Update the internal version of pybind11, version 2.3.0. This release includes several fixes, such as - add fix pybind/pybind11#1434 and can compute all function signatures at compile-time in C++11 mode via `constexpr`, leading to smaller binaries. https://github.com/pybind/pybind11/blob/v2.3.0/docs/changelog.rst Modifications from the releases: - remove test dirs - remove wheel packaging (setup.py/cfg) - remove github templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful not only to remember the python libs and includes but also the interpreter version in cache.
If users call pybind11 throught
add_subdirectoriesthey will otherwise have no access to the selected interpreter version. The interpreter version is useful for downstream projects, e.g. to select defaultlib/pythonX.Y/site-packages/install paths.Fix pybind/cmake_example#13