Make sure detail::get_internals acquires the GIL before making Python calls
#1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saran-t
force-pushed
the
get_internals_gil
branch
2 times, most recently
from
720465a
to
e553bce
Compare
…on calls. This is only necessary if `get_internals` is called for the first time in a given module when the running thread is in a GIL-released state. Fixes pybind#1364
saran-t
force-pushed
the
get_internals_gil
branch
from
e553bce
to
36b9c4b
Compare
|
closed following #1364. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only necessary if
get_internalsis called for the first time in a given module when the running thread is in a GIL-released state.Fixes #1364