fix: Intel 18+ required #2577
Merged
fix: Intel 18+ required #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup on pybind#94 now that Intel 18+ is required.
|
Yes. We can't test anything before 20.2 in CI AFAIK due to Intel licensing. |
Booooooooo! Well, not our problem, then, if Intel won't help us support their compiler... |
|
LGTM! |
|
Sadly this doesn't solve the instant segfault for 20.2, though, seen in #2573 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops an old workaround for #94, and adds a workaround developed for PGI in #2479.
I've tried to build 2.5.0, 2.4.0, 2.3.0, 2.2.0, and 2.0.0 on Intel 17, and none of them can build the py::vectorize code in the tests. Intel 18 seems to be the first one that can. So I think we should simply say we support Intel 18+, and drop the list of older versions that support Intel 16 and 15, since the support wasn’t even complete and these versions are quite old now anyway.
Also gathering a bit of readme cleanup I'd been collecting.
Tested on 18.0 and 19.1.