smart_holder trampoline shared_from_this support #3023
Commits on Jun 29, 2021
-
Experiments: 1. disabling enable_shared_from_this, 2. using smart_hol…
…der in test_class_sh_shared_from_this.cpp
-
Breaking up test_shared_ptr_from_this_and_references into smaller sub…
…tests. Skipping the only test that generates an ASAN heap-use-after-free.
-
Restoring init_holder overload for std::enable_shared_from_this and o…
…riginal tests/test_smart_ptr.py.
-
-
enable_shared_from_this_from_raw_ptr_take_ownership_guard: better sta…
…tic_assert that also triggers for derived classes.
-
Fully emulating type_caster_base-related behavior: trying shared_from…
…_this also for unowned pointees.
-
-
-
Revert "Experiment: restoring original smart_holder_type_casters.h fr…
…om smart_holder branch." This reverts commit 19c5a36.
-
Revert "Experiment: effectively undoing all shared_from_this modifica…
…tions." This reverts commit d72d54e.
-
Revert "Experiment: commenting out test_class_sh_shared_from_this."
This reverts commit febf9ce.
-
Copying in shared_from_this_custom_deleters.cpp from github.com/rwgk,…
… with adjustments. Base version: https://github.com/rwgk/stuff/blob/e5318faa6a8583b7c338e01398a4eea69abda08d/shared_from_this_custom_deleters.cpp
-
-
-
-
-
WIP snapshot: replacing
std::shared_ptr<bool> flag_ptrwith simple ……`bool armed_flag`.
-
-
Inserting
const_castforstd::get_deleterreturn, to keep Ubuntu ……20 GCC 6.3.0 happy.
-
Adding back explicit but default copy constructor, to keep some older…
… compilers happy.
-
-
First attempt to make shared_from_this and trampolines play nicely. P…
…asses all pybind11 and PyCLIF unit tests ASAN clean, but not the open_spiel iterated_prisoners_dilemma_test.
-
First fully successful attempt to make
shared_from_thisand trampol……ines play nicely. Now also passes the open_spiel iterated_prisoners_dilemma_test ASAN clean, in addition to all pybind11 and PyCLIF unit tests. The problem was that calling `std::shared_ptr<void>::reset()` with a `void` pointer cannot possibly update the `shared_from_this` `weak_ptr`. The solution is to store a `shd_ptr_reset` function pointer in `guarded_deleter` (similar in idea to the stored function pointer for calling `delete`). This commit still includes all debugging code, i.e. is "dirty". The code will be cleaned up after the GitHub CI is fully successful.
-
-
-
-
-
Adding
test_pass_released_shared_ptr_as_unique_ptr, exercising new ……guard in smart_holder_type_casters.h.
-
-
Leveraging new
noop_deleter_acting_as_weak_ptr_ownerto retrieve re……leased `vptr`. The placeholder `vptr` is never exposed anymore, therefore the externally visible `use_count`s are more intuitive.
-
-
smart_holder_poc.h: type-erase raw_ptr before passing to shared_ptr::…
…reset, to not trigger populating the shared_from_this weak_ptr. This way the only way the weak_ptr is populated is through loaded_as_shared_ptr. Breaks all but one test in test_class_sh_trampoline_shared_from_this.py, now marked skip WIP to test everything else with the GitHub CI.
-
Simpler and safe implementation based on new requirement: C++ (outsid…
…e of the Python object) needs to hold a shared_ptr before shared_from_this is called. This is more similar to the existing implementation on current smart_holder HEAD, but still uses a weak_ptr to always return the same shared_ptr as long as C++ does not let it expire.
-
-
-
Adding test_pure_cpp_sft_raw_ptr (with 3 TODO: Fix), test_pure_cpp_sf…
…t_shd_ptr (works as desired).
-
Preparation for being smarter about casting to
void *to evade to s……hared_from_this mechanism.
-
Use casting to
void *to evade to shared_from_this mechanism only i……f `pointee_depends_on_holder_owner`, but currently only for `from_raw_ptr_take_ownership`.
-
Resolving TODOs for
from_unique_ptrvoid_cast_raw_ptr. Adding tes……t to exercise the path through `cast`. The path through init.h is missing a test that would fail if the flag is incorrect. The plan is to systematically cover all situations (there are many that are not exercised for shared_from_this).
-
-
Updating Catch version to latest, in hopes of resolving the GHA downl…
…oad issue affecting all MSVC builds.
-
Revert "Updating Catch version to latest, in hopes of resolving the G…
…HA download issue affecting all MSVC builds." This reverts commit f4e1112. It didn't help.
-
-
-
This change fixes the 6 unit tests in
https://github.com/deepmind/open_spiel/tree/bbfb0259b5d26c1e3f05000f1f4a05b7ad60393e/open_spiel/python/mfg/algorithms best_response_value_test distribution_test fictitious_play_test greedy_policy_test nash_conv_test policy_value_test CAVEAT: The fix is NOT covered by pybind11 unit tests.
-
Adding unit tests: 2 x test_std_make_shared_factory
Completes unit test coverage for the changed code in smart_holder_type_casters.h.
-
-
Adding test_multiple_registered_instances_for_same_pointee_leak. Subt…
…le changes in smart_holder_type_caster_load, trying to work on weak_ptr for shared_ptr_trampoline_self_life_support, but that didn't work out. Manually fully leak-checked again.
-
-
