Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style:(pre-commit) Add shellcheck style checking #3114

Merged
merged 1 commit into from Jul 14, 2021
Merged

style:(pre-commit) Add shellcheck style checking #3114

merged 1 commit into from Jul 14, 2021

Conversation

Skylion007
Copy link
Collaborator

Description

  • Adds a linter for shell scripts which helps improve our shellscripts

Suggested changelog entry:

* Adds a shellcheck-py pre-commit hook and improve style of shell scripts

@Skylion007 Skylion007 requested review from rwgk and henryiii July 14, 2021 20:27
@Skylion007 Skylion007 mentioned this pull request Jul 14, 2021
Merged
@henryiii
Copy link
Collaborator

We don't have many shell scripts ( 😄 ), but good.

@Skylion007 Skylion007 changed the title (pre-commit) Add shellcheck style checking style:(pre-commit) Add shellcheck style checking Jul 14, 2021
@Skylion007 Skylion007 merged commit c4b0dc7 into pybind:master Jul 14, 2021
@Skylion007 Skylion007 deleted the pre-commit-shellcheck branch July 14, 2021 20:52
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jul 14, 2021
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jul 15, 2021
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii approved these changes

@rwgk rwgk Awaiting requested review from rwgk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Skylion007 @henryiii