Removing obsolete eigen.h warning suppression pragmas. #3198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwgk
changed the title
rwgk
changed the title
rwgk
force-pushed
the
eigen_pragma
branch
2 times, most recently
from
5311594
to
de66873
Compare
… 3.14 or newer). Also changing all `cmake -t` to `--target`, `-v` to `--verbose`, `check` to `pytest`, for consistency (to make it easier to pin-point all commands of a certain type). Also removing one `-j 2` for `pytest` in hopes of reducing flakes due to races in test_iostream and in prints from destructors.
…ding HINT use -isystem (as cmake does).
rwgk
changed the title
rwgk
changed the title
…tely. BTW: in the last CI run there was still a test_iostream flake, even without the -j 2 for running the tests (verfied by inspecting the log).
Skylion007
approved these changes
Aug 17, 2021
|
Thanks @Skylion007! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long story short: the
pragmas in eigen.h are simply not needed when using-isystem, as all non-Windows CI jobs do.A
HINT ... use -isystemwas added to eigen.h.For MSVC the existing
PYBIND11_SILENCE_MSVC_C4127macro was added in 4 locations.For completeness, the existing
pragmas have several issues:__INTEL_COMPILERpragmais not pushed (it applies globally from the point of including eigen.h).#ifdeflogic forpush/popis inconsistent, which may or may not matter (see e.g. https://stackoverflow.com/questions/38499462/how-to-tell-clang-to-stop-pretending-to-be-other-compilers).Luckily, we can just purge the
pragmas completely.Suggested changelog entry: