Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use almalinux instead of centos, add 9 #4020

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Jun 20, 2022

Description

AlmaLinux is used by manylinux, so let's use that here.

Suggested changelog entry:

None needed, CI.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it would be useful to add this to the changelog?

Testing with Centos 8 was replaced with AlmaLinux 8. Testing with AlmaLinux 9 was added.

I think that would be useful to highlight in the changelog because from a practical viewpoint that means we are dropping support for Centos 8, but are adding support for AlmaLinux 8 & 9.

@henryiii
Copy link
Collaborator Author

Not really, we support RHEL 7, 8, and 9. We just use CentOS's repackaging for 7 and AlmaLinux repackaging for 8 & 9. We could use RockyLinux and it would be the same. Or, since I'm at Princeton, maybe Springdale. ;) For an end user, RHEL 7-9 is the important thing, not how it's been debranded and rebuilt.

@henryiii
Copy link
Collaborator Author

henryiii commented Jun 21, 2022

I also believe we don't advertise the list of OS's we build on, just compiler versions. Could be wrong though.

We are avoiding stream distros - I think we were supporting 8 stream, which we aren't now. But we are now testing on 9 anyway, and we've never supported1/tested Fedora or even non LTS Ubuntu either.

Footnotes

  1. Supported by testing. I'd assume they work, and I'd try to fix them on a best-effort basis if they didn't.

@henryiii henryiii merged commit c3e9173 into pybind:master Jun 21, 2022
@henryiii henryiii deleted the henryiii/ci/alma branch June 21, 2022 18:55
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jun 21, 2022
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants