fix pybind11Tools.cmake typo causing Unknown arguments #4327
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake Error at pybind11/tools/pybind11Tools.cmake:217 (if):
if given arguments:
"NOT" "MSVC" "AND" "NOT" "TEST" "MATCHES" "DEBUG|RELWITHDEBINFO"
Unknown arguments specified
#4325
|
@ddinu could you please help reviewing this PR? — I don't know much about cmake, in particular the rules for using quotes. |
|
This looks ok to me, but please make the same change in the pybind11NewTools.cmake file too. |
|
I guess it's triggering a keyword TEST instead of "TEST" the string. Agree, same change in both places. |
ddinu
approved these changes
Nov 12, 2022
|
The CI run sets a new record for the number of clearly unrelated flakes:
Rerunning these is pointless, the cmake changes are more than certainly covered. I'll go ahead and merge this PR. Thanks @ddinu for the review. Thanks @gitartpiano for the fix. |
rwgk
added a commit
that referenced
this pull request
Nov 18, 2022
* fix pybind11Tools.cmake typo causing Unknown arguments
CMake Error at pybind11/tools/pybind11Tools.cmake:217 (if):
if given arguments:
"NOT" "MSVC" "AND" "NOT" "TEST" "MATCHES" "DEBUG|RELWITHDEBINFO"
Unknown arguments specified
#4325
* Apply the same fix in tools/pybind11NewTools.cmake
Co-authored-by: Ralf W. Grosse-Kunstleve <rwgk@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CMake Error at pybind11/tools/pybind11Tools.cmake:217 (if):
if given arguments:
"NOT" "MSVC" "AND" "NOT" "TEST" "MATCHES" "DEBUG|RELWITHDEBINFO"
Unknown arguments specified
#4325
The code that needs the fix was introduced with PR #4078.
Suggested changelog entry: