CI: Reenable an NVHPC Test #4764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
force-pushed
the
ci-nvhpc-reenable
branch
5 times, most recently
from
592b0ce
to
244c1a2
Compare
Update from CentOS to Ubuntu and to a recent version of NVHPC (former: PGI).
|
BTW: I'm testing a fix for the Clang dev failure: Good to ignore here. |
Skylion007
approved these changes
Jul 26, 2023
rwgk
reviewed
Jul 26, 2023
| -DCMAKE_CXX_STANDARD=11 \ | ||
| module load /opt/nvidia/hpc_sdk/modulefiles/nvhpc/23.5 | ||
| cmake -S . -B build -DDOWNLOAD_CATCH=ON \ | ||
| -DCMAKE_CXX_STANDARD=17 \ | ||
| -DPYTHON_EXECUTABLE=$(python3 -c "import sys; print(sys.executable)") \ | ||
| -DCMAKE_CXX_FLAGS="-Wc,--pending_instantiations=0" \ | ||
| -DPYBIND11_TEST_FILTER="test_smart_ptr.cpp" |
There was a problem hiding this comment.
This comment is removed (seems great):
we have to filter a few tests (compiler internal error)
But we still have the PYBIND11_TEST_FILTER here. Could you please try removing it?
While you're at it, maybe also piggy-back 1fb7dc3?
There was a problem hiding this comment.
While you're at it, maybe also piggy-back 1fb7dc3?
No, don't, it breaks centos:7 :-(
https://github.com/pybind/pybind11/actions/runs/5672904152/job/15373167218
I'll sort this out separately.
|
I just updated this PR to
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update from CentOS to Ubuntu and to a recent version of NVHPC (former: PGI).
Fix #4690
Follow-up to #4691
Suggested changelog entry: