Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smart_holder] Dummy change. Just to trigger CI. #5175

Closed

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Jun 19, 2024

Description

Dummy change. Just to trigger CI (similar to #3939 for master).

Suggested changelog entry:

@rwgk
Copy link
Collaborator Author

rwgk commented Jun 19, 2024

Re failures for:

3 • Clang dev • C++11 • x64

Last succeeding:

Tue, 11 Jun 2024 23:12:01 GMT
C++ Info: Debian Clang 19.0.0 (++20240514105158+3ca428c09062-1~exp1~20240514225211.712)

First failing:

Wed, 19 Jun 2024 17:28:01 GMT

From log on master (using #3939):

C++ Info: Debian Clang 19.0.0 (++20240619112312+5dde4951ae16-1~exp1~20240619112324.785)

@rwgk
Copy link
Collaborator Author

rwgk commented Jun 19, 2024

Copy of error message:

For easy reference, this is the clang version:

C++ Info: Debian Clang 19.0.0 (++20240619112312+5dde4951ae16-1~exp1~20240619112324.785)
d /__w/pybind11/pybind11/build/tests && /usr/bin/c++ -DPYBIND11_ENABLE_TYPE_CASTER_ODR_GUARD_IF_AVAILABLE -DPYBIND11_TEST_EIGEN -Dpybind11_tests_EXPORTS -I/__w/pybind11/pybind11/include -isystem /usr/include/python3.11 -isystem /usr/include/eigen3 -Os -DNDEBUG -fPIC -fvisibility=hidden -Wall -Wextra -Wconversion -Wcast-qual -Wdeprecated -Wundef -Wnon-virtual-dtor -Werror -flto -std=c++11 -MD -MT tests/CMakeFiles/pybind11_tests.dir/pybind11_tests.cpp.o -MF CMakeFiles/pybind11_tests.dir/pybind11_tests.cpp.o.d -o CMakeFiles/pybind11_tests.dir/pybind11_tests.cpp.o -c /__w/pybind11/pybind11/tests/pybind11_tests.cpp
In file included from /__w/pybind11/pybind11/tests/pybind11_cross_module_tests.cpp:10:
In file included from /__w/pybind11/pybind11/include/pybind11/stl_bind.h:15:
In file included from /__w/pybind11/pybind11/include/pybind11/operators.h:12:
In file included from /__w/pybind11/pybind11/include/pybind11/pybind11.h:14:
/__w/pybind11/pybind11/include/pybind11/detail/init.h:221:53: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  221 |     auto smhldr = type_caster<Cpp<Class>>::template smart_holder_from_unique_ptr(
      |                                                     ^
/__w/pybind11/pybind11/include/pybind11/detail/init.h:2[36](https://github.com/pybind/pybind11/actions/runs/9586053423/job/26433234621?pr=5175#step:6:37):55: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  236 |     auto smhldr = type_caster<Alias<Class>>::template smart_holder_from_unique_ptr(
      |                                                       ^
/__w/pybind11/pybind11/include/pybind11/detail/init.h:253:53: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  253 |     auto smhldr = type_caster<Cpp<Class>>::template smart_holder_from_shared_ptr(shd_ptr);
      |                                                     ^
/__w/pybind11/pybind11/include/pybind11/detail/init.h:266:55: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  266 |     auto smhldr = type_caster<Alias<Class>>::template smart_holder_from_shared_ptr(shd_ptr);
      |                                                       ^
In file included from /__w/pybind11/pybind11/tests/pybind11_tests.cpp:10:
In file included from /__w/pybind11/pybind11/tests/pybind11_tests.h:3:
In file included from /__w/pybind11/pybind11/include/pybind11/eval.h:14:
In file included from /__w/pybind11/pybind11/include/pybind11/pybind11.h:14:
/__w/pybind11/pybind11/include/pybind11/detail/init.h:221:53: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  221 |     auto smhldr = type_caster<Cpp<Class>>::template smart_holder_from_unique_ptr(
      |                                                     ^
/__w/pybind11/pybind11/include/pybind11/detail/init.h:236:55: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  236 |     auto smhldr = type_caster<Alias<Class>>::template smart_holder_from_unique_ptr(
      |                                                       ^
/__w/pybind11/pybind11/include/pybind11/detail/init.h:2[53](https://github.com/pybind/pybind11/actions/runs/9586053423/job/26433234621?pr=5175#step:6:54):53: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  253 |     auto smhldr = type_caster<Cpp<Class>>::template smart_holder_from_shared_ptr(shd_ptr);
      |                                                     ^
/__w/pybind11/pybind11/include/pybind11/detail/init.h:266:[55](https://github.com/pybind/pybind11/actions/runs/9586053423/job/26433234621?pr=5175#step:6:56): error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  266 |     auto smhldr = type_caster<Alias<Class>>::template smart_holder_from_shared_ptr(shd_ptr);
      |                                                       ^
4 errors generated.

@rwgk
Copy link
Collaborator Author

rwgk commented Jun 19, 2024

This is the calling code triggering the error:

  • auto smhldr = type_caster<Cpp<Class>>::template smart_holder_from_unique_ptr(
    std::move(unq_ptr), /*void_cast_raw_ptr*/ Class::has_alias && is_alias<Class>(ptr));

This is the called code:

  • template <typename T, typename D>
    static smart_holder smart_holder_from_unique_ptr(std::unique_ptr<T, D> &&unq_ptr,
    bool void_cast_raw_ptr) {
    void *void_ptr = void_cast_raw_ptr ? static_cast<void *>(unq_ptr.get()) : nullptr;
    return pybindit::memory::smart_holder::from_unique_ptr(std::move(unq_ptr), void_ptr);
    }

rwgk pushed a commit to rwgk/pybind11 that referenced this pull request Jun 19, 2024
rwgk pushed a commit that referenced this pull request Jun 19, 2024
@rwgk
Copy link
Collaborator Author

rwgk commented Jun 19, 2024

clang 19.0.0 dev is correct. Long-standing misunderstanding of mine, resolved via #5176.

@rwgk rwgk closed this Jun 19, 2024
@rwgk rwgk deleted the smart_holder_with_dummy_change branch June 19, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant