feat(types): add support for typing.Literal type #5192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwgk
reviewed
Jun 25, 2024
include/pybind11/typing.h
Outdated
| char name[N]; | ||
| }; | ||
|
|
||
| // NOTE: C++ implemented constant template Literal[1, 2] does not equal Literal[2, 1] |
There was a problem hiding this comment.
Could this be simplified?
// NOTE: Literal[1, 2] does not equal Literal[2, 1]
But why is this noteworthy here? (IOW, where/why does it matter?)
There was a problem hiding this comment.
Oops this comment was left from a previous implementation. It has now been removed.
henryiii
approved these changes
Jun 25, 2024
henryiii
changed the title
henryiii
changed the title
rwgk
approved these changes
Jun 25, 2024
|
Don't worry about this failure: Pip / 🐍 3.8 • 📦 & 📦 tests • ubuntu-latest It's just some kind of infrastructure hiccup that we can safely ignore here. (Similar hiccups happen all the time.) |
|
Twine is broken. Working on fix at pypa/twine#1126. |
|
And I'm avoiding the breakage at #5196. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements support for typing.Literal
Example declaration.
Allows more narrow return types of python objects.
Suggested changelog entry:
Adds support for `typing.Literal`.