Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct location for URL #1126

Closed
wants to merge 1 commit into from

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Jun 25, 2024

Alternative to #1124, fixing the issue rather than hiding the error. Requires #1123.

@jaraco
Copy link
Member

jaraco commented Jun 25, 2024

I'm pretty sure the assignment of __author__ is also broken, based on the reported DeprecationWarnings.

@henryiii
Copy link
Contributor Author

Yes, I think you are right. These dunder attributes aren't a standard anyway (a failed standard, technically), I wonder if it would be fine to just remove them?

@henryiii
Copy link
Contributor Author

"wheel" should also be removed from pyproject.toml.

twine/package.py Outdated Show resolved Hide resolved
twine/__init__.py Outdated Show resolved Hide resolved
twine/__init__.py Outdated Show resolved Hide resolved
@henryiii
Copy link
Contributor Author

Setting the metaadata version too high is now a warning instead of an error; how should that be handled? Covert to error, or just test for the warning?

@henryiii
Copy link
Contributor Author

Ahh, needs #1123. I can rebase on that.

@henryiii
Copy link
Contributor Author

You won't actually be able to release without yanking 5.1.0, though, since

uses: "pypa/gh-action-pypi-publish@81e9d935c883d0b210363ab89cf05f3894778450"
is broken due to twine being broken! :)

@henryiii
Copy link
Contributor Author

Hmm, looks like it's pinned, not sure why pypa/gh-action-pypi-publish#246 exists then.

@jaraco jaraco changed the base branch from main to bugfix/1116-pkginfo-warnings June 25, 2024 22:55
@jaraco
Copy link
Member

jaraco commented Jun 25, 2024

I've changed the base of the PR to target the branch for #1123 so that the diff is apparent. I expect GitHub to re-target main after #1123 is merged.

@jaraco
Copy link
Member

jaraco commented Jun 26, 2024

A very similar patch was proposed in #1115. Perhaps we should accept that instead, since it was proposed first. Also, it re-uses the email module to parse the email field, which seems preferable.

@JohnVillalovos
Copy link

A very similar patch was proposed in #1115. Perhaps we should accept that instead, since it was proposed first. Also, it re-uses the email module to parse the email field, which seems preferable.

Makes sense. They went through all the effort 28 days ago to fix it...

@henryiii
Copy link
Contributor Author

Okay, I'm going to close this to make sure that one is the one that goes in. I like the usage of the email module better too.

@henryiii henryiii closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants