-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use correct location for URL #1126
Conversation
I'm pretty sure the assignment of |
Yes, I think you are right. These dunder attributes aren't a standard anyway (a failed standard, technically), I wonder if it would be fine to just remove them? |
"wheel" should also be removed from pyproject.toml. |
Setting the metaadata version too high is now a warning instead of an error; how should that be handled? Covert to error, or just test for the warning? |
Ahh, needs #1123. I can rebase on that. |
You won't actually be able to release without yanking 5.1.0, though, since twine/.github/workflows/release.yml Line 79 in 6fbf880
|
Hmm, looks like it's pinned, not sure why pypa/gh-action-pypi-publish#246 exists then. |
A very similar patch was proposed in #1115. Perhaps we should accept that instead, since it was proposed first. Also, it re-uses the email module to parse the email field, which seems preferable. |
Makes sense. They went through all the effort 28 days ago to fix it... |
Okay, I'm going to close this to make sure that one is the one that goes in. I like the usage of the email module better too. |
Alternative to #1124, fixing the issue rather than hiding the error. Requires #1123.