Fix segfault when repr() with pybind11 type with metaclass #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When filling the ht_qualname field of the metaclass PyHeapTypeObject, the object shouldn't be released. Otherwise later the major type object receives a NULL ht_qualname, and then __repr__() results into segfault (typeobject.c:type_qualname() increment the ref count unconditionally by Py_INCREF(et->ht_qualname)). Note that pickler relies on repr, and crashes as well.
|
I think the issue here is actually that it should read instead of (introduced by accident with the PyPy patch). Could you adapt the PR accordingly? Thanks, |
…ht_qualname field. Change 806b677 incorrectly inc_ref'ed ht_qualname, which left ht_qualname_meta remains unused.
|
That's right. I overlooked it. Thanks for pointing it out, @wjakob. Please let me know if the multiple checkins should be be combined into one. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the
ht_qualnamefield forPyHeapTypeObjectwith metaclass.When filling the
ht_qualnamefield of the metaclassPyHeapTypeObject, the object shouldn't be released. Otherwise later the major type object receives a NULLht_qualname, and then__repr__()results into segfault (typeobject.c:type_qualname()increments the ref count unconditionally byPy_INCREF(et->ht_qualname)).Note that pickler relies on repr, and crashes as well. If needed I can provide a test case.