Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC - Add documentation for strings and Unicode issues #636

Merged
merged 3 commits into from Feb 2, 2017

Conversation

jbarlow83
Copy link
Contributor

I requested this in #591. Thanks to clarifications from @jagerman in that issue I felt I had gather enough information to contribute this myself. Comments welcome.

@jbarlow83
Copy link
Contributor Author

I concede that I am not personally interested in anything to do with wide characters and welcome expansion to that section if anyone feels a need.

@wjakob
Copy link
Member

wjakob commented Feb 1, 2017

I think this looks great, but a few words about wstring and wchar_t should indeed be added to remark on the fact that these are also supported. All that needs to be said is that these do the proper thing analogous to u16string, etc., but what that is specifically depends on the platform. wstring and wchar_t are particularly important on Windows since the native WIN32 API makes frequent use of strings using the same encoding. So if you want to wrap a native WIN32 function, you'll want to use these.

@jbarlow83
Copy link
Contributor Author

Okay, I modified a simple Win32 example from a Microsoft article and some details about characters literals.

@wjakob
Copy link
Member

wjakob commented Feb 2, 2017

This is great -- thank you for such an in-depth writeup!

@wjakob wjakob merged commit 40db2c7 into pybind:master Feb 2, 2017
@rwgk rwgk mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants