-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support class-specific operator new and delete #755
Conversation
Looks good to me. |
I'd recommend this waits for v2.2 since it does affect a pretty key part of class support. Also might need to see about future-proofing for C++17 alignment-aware |
C++17 support can definitely wait for 2.2, but I think the current PR fixes an important issue that is likely going to come up again in 2.1's stable lifetime (given the improved Eigen support in 2.1). |
I've merged this now so that it can be part of 2.1 |
Note: Clang 4.0 doesn't compile in C++17mode due to |
Whoops, didn't notice that. Should we promote the gcc7/clang4 builds to non-optional? (clang 4.0 is building with the stable released version now; gcc7 is still a snapshot, so perhaps just clang 4?) |
I just pushed a fix for clang 4.0: f0e58a6 |
Just out of curiosity: what's the issue with __cpp_lib_void_t? Does Clang define it but then not offer |
No, it isn't working as its supposed to. http://bugs.llvm.org/show_bug.cgi?id=26086 is the issue, I believe. |
... which basically means LLVM libc++'s |
Exactly that. The new-style implementation of Anyway, I just removed |
Fixes #754.
void_t
was needed to work around a GCC 4.8 issue, but it's pretty useful to have anyway.