Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing default globals in eval/exec when embedding #889

Merged
merged 1 commit into from
Jun 7, 2017
Merged

Fix missing default globals in eval/exec when embedding #889

merged 1 commit into from
Jun 7, 2017

Conversation

dean0x7d
Copy link
Member

@dean0x7d dean0x7d commented Jun 6, 2017

Fixes #887.

PyEval_GetGlobals() by default and __main__.__dict__ as a fallback. This also moves the globals logic from py::eval() into py::globals() for consistency.

@jagerman
Copy link
Member

jagerman commented Jun 6, 2017

👍

@dean0x7d dean0x7d merged commit 1d3c4bc into pybind:master Jun 7, 2017
@dean0x7d dean0x7d mentioned this pull request Jun 7, 2017
Closed
@dean0x7d dean0x7d deleted the fix-exec-default branch June 7, 2017 09:52
@dean0x7d dean0x7d modified the milestone: v2.2 Aug 13, 2017
@rwgk rwgk mentioned this pull request Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@dean0x7d @jagerman