std::string_view support #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dean0x7d
reviewed
Jun 23, 2017
docs/advanced/cast/overview.rst
Outdated
| @@ -116,6 +116,10 @@ as arguments and return values, refer to the section on binding :ref:`classes`. | |||
| +------------------------------------+---------------------------+-------------------------------+ | |||
| | ``std::wstring`` | STL dynamic wide string | :file:`pybind11/pybind11.h` | | |||
| +------------------------------------+---------------------------+-------------------------------+ | |||
| | ``std::string_view``, | STL C++17 string views | :file:`pybind11/pybind11.h` | | |||
| | ``std::u16string_view``, | (only available when | | | |||
| | etc. | compiling in C++17 mode) | | | |||
There was a problem hiding this comment.
I don't think the text in parentheses is necessary. Just mentioning C++17 is enough.
Wrapped long lines and removed a few trailing spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
std::string_view(and related, e.g.std::u16string_view) by making the currentstd::stringcaster slightly more generic so that it can support bothstd::strings andstd::string_views.It also includes commits that update the
strings.rstdocumentation with style fixes (wrapping, trailing whitespace removal) to the strings.rst documentation, and one minor wording fix. (They don't really have anything to do with the PR aside from me noticing them when writing it).Fixes #905
I've added the
<string_view>include for this directly incast.hrather than push it intostl.h: both stdlibc++ and libc++ already#include <string_view>as an implementation detail of#include <string>when compiling in C++17 mode, so the extra header isn't actually pulling in more STL code in practice.