Updates #28
Merged
Updates #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed validate_single_root_transform
This one is straightforward enough, it's now called
validate_single_assemblyAdded support to find_next_version for multiple numbers
Before, numbers couldn't go above 10, this was a bug and is fixed now.
Adding option for extractor
Made it so that maya_ascii publishes don't include their original references; instead they are baked into the publish.
Renaming integrate_cleanup.py to cleanup_tempdir.py
To better align with the new
cleanup_comment.py.Added support for comments
When publishing, it looks for a node of any type called "comment". If it has anything in it's "notes" field, it will be published as "comment.txt" alongside everything else.
The comment is then removed during
CleanupComment.Moving temp_dir to Context, for simplified integration
Something to talk about; before, the temp directory was embedded into each Instance, meaning integration operated on a per-instance basis. I moved the temp dir to the Context now, such that integration simply moves everything inside of it into it's corresponding version.
Benefit is simpler integration, disadvantage is less control over individual files as we no longer have access to files relative to which instance they came from. Whether or not it matters remains to be seen.
Does it make sense though? It might not have been necessary, it's just a trail.