Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Document moved dc settings limit #536

Closed
laurensvalk opened this issue Nov 18, 2021 · 1 comment
Closed

[Doc] Document moved dc settings limit #536

laurensvalk opened this issue Nov 18, 2021 · 1 comment
Assignees
@laurensvalk
Labels
documentation Improvements or additions to documentation topic: motors Issues involving motors

Comments

@laurensvalk
Copy link
Member

This method is now part of the DCMotor class, inherited by Motor. Instead of setting the duty cycle limit, this sets the maximum voltage.

Also need to check implementation for backwards compatibility.
@laurensvalk laurensvalk added documentation Improvements or additions to documentation topic: motors Issues involving motors labels Nov 18, 2021
@laurensvalk laurensvalk self-assigned this Nov 18, 2021
@laurensvalk
Copy link
Member Author

laurensvalk commented Nov 18, 2021 •
edited
Loading

Also need to check implementation for backwards compatibility.

We can reinstate the duty limit setter for backwards compatibility. It was deleted because it is not a control property, but a motor property. The duty limit has no meaning in heading_control, for example.

@laurensvalk laurensvalk added this to the v3.1 milestone Nov 18, 2021
@laurensvalk laurensvalk removed this from the v3.1 milestone Nov 19, 2021
laurensvalk added a commit to pybricks/pybricks-api that referenced this issue Dec 1, 2021
@laurensvalk
pybricks.pupdevices.DCMotor: Document settings method.
06a1542 
See pybricks/support#536
laurensvalk added a commit to pybricks/pybricks-api that referenced this issue Dec 1, 2021
@laurensvalk
pybricks.common.Control: Drop duty limit.
eb09ecd 
This is now a per-motor voltage limit.

See pybricks/support#536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurensvalk laurensvalk

Labels
documentation Improvements or additions to documentation topic: motors Issues involving motors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laurensvalk