list_packages not working correctly

[MirkoRossini]

Hello,

I just started using pyb on an existing project. I ran into a weird issue where the first letter of all packages was missing in all the packages in setup.py. i.e. I have:

packages = ['oaders', 'awdata', 'onfig',..]

instead of

packages = ['loaders', r'awdata', 'config',..]

I fixed by redefining Project.list_packages in build.py, removing the [1:] splice (see core_plugin.py)
I may be doing something wrong with my configuration, but I didn't change many default values:

from pybuilder.core import use_plugin, init
use_plugin("python.core")
use_plugin("python.unittest")
use_plugin("python.flake8")
use_plugin("python.coverage")
use_plugin("python.distutils")

name = "loader"
default_task = ["publish"]

@init
def set_properties(project):
project.set_property('coverage_break_build', False)
project.set_property("dir_source_main_python", "src/")
project.set_property("dir_source_unittest_python", "test/")
project.set_property("dir_source_main_scripts", "src/scripts/")
project.set_property("dir_dist_scripts", 'scripts')
project.depends_on_requirements("requirements.txt")
project.depends_on("django-altauth", url = "git+https://github.com/MirkoRossini/django-altauth.git")

Thanks

Mirko

[mriehl]

Actually the override path properties are not supposed to have a trailing slash, that's why pybuilder is eating a character from the package.

I guess it would be cleaner to check for the trailing slash case and handle it, so that's what I'll do. Thanks for the report!

[MirkoRossini]

Thanks, I'll remove the trailing slashes.
FYI I used the interactive command line interface that starts with --start-project, so those properties were automatically generated. Maybe the check should be done at that level

Mirko

[mriehl]

It's as I thought. You start out with the path to your package, say

/workspace/project/src/package/subpackage
pybuilder then removes the source path from there, which is
/workspace/project/src

so this leaves
/package/subpackage where you need to strip the leading slash.

But if your source path is
/workspace/project/src/ then you don't have that leading slash.

Both variants (trailing slash / no trailing slash) should work now. Thanks again for reporting!

[mriehl]

@aelgru do you want to review/release this?

[MirkoRossini]

Thanks for the quick fix!

[mriehl]

I just released v0.10.35 which includes the fix to this issue.