Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing test coverage on vcs_tests.py #439

Merged
merged 2 commits into from
Dec 18, 2016
Merged

Increasing test coverage on vcs_tests.py #439

merged 2 commits into from
Dec 18, 2016

Conversation

jima80525
Copy link

Just getting the hang of doing development on this tree. Thought I'd pick a file and finish its test coverage.

@coveralls
Copy link

coveralls commented Dec 16, 2016

Coverage Status

Coverage decreased (-1.3%) to 71.908% when pulling aa3d75d on jima80525:master into deb92d4 on pybuilder:master.

@arcivanov
Copy link
Member

@jima80525 welcome to the joys of supporting Python 2.6 😉

@jima80525
Copy link
Author

Looks like I failed to take 2.6 into account. Will fix.

One question (in case anyone reads this). How is it reporting that coverage went down? The only thing I did was add unit tests for uncovered code. Hmmm

@arcivanov
Copy link
Member

The report is correct. Since Python 2.6 failed its coverage didn't count. Therefore all of the Python 2.6 code branches ended up not covered.

@jima80525
Copy link
Author

Thanks!

@coveralls
Copy link

coveralls commented Dec 17, 2016

Coverage Status

Coverage increased (+0.3%) to 73.506% when pulling 938ee52 on jima80525:master into deb92d4 on pybuilder:master.

@arcivanov arcivanov merged commit 224567f into pybuilder:master Dec 18, 2016
@arcivanov
Copy link
Member

Thanks!

@esc
Copy link
Contributor

esc commented Dec 19, 2016

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants